chore: Remove bootstrapValidator CSS includes#1125
Merged
JohnVillalovos merged 1 commit intoLibreBooking:developfrom Mar 9, 2026
Merged
chore: Remove bootstrapValidator CSS includes#1125JohnVillalovos merged 1 commit intoLibreBooking:developfrom
JohnVillalovos merged 1 commit intoLibreBooking:developfrom
Conversation
Delete conditional inclusion of bootstrapValidator CSS from tpl/globalheader.tpl. This removes both the local cssfile vendor import and the CDN stylesheet link for the Validator, cleaning up an unused dependency.
JohnVillalovos
force-pushed
the
cleanup-bootstrapvalidator-css
branch
from
771ab21 to
bc0904b
Compare
Collaborator
|
Is this to resolve #1115 ? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the conditional bootstrapValidator CSS includes from tpl/globalheader.tpl, cleaning up both the local cssfile vendor import and the CDN stylesheet link that were gated behind the $Validator flag.
Changes:
- Remove the
{if isset($Validator) && $Validator}block that included the localcss/bootstrapValidator.min.cssvia{cssfile}. - Remove the corresponding CDN
<link>forcdnjs.cloudflare.com/.../bootstrapValidator.min.cssin the non-local block.
You can also share your feedback on Copilot code review. Take the survey.
JohnVillalovos
approved these changes
Mar 9, 2026
Collaborator
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete conditional inclusion of bootstrapValidator CSS from tpl/globalheader.tpl. This removes both the local cssfile vendor import and the CDN stylesheet link for the Validator, cleaning up an unused dependency.
Closes: #1115