Skip to content

Conversation

AntDavidLima
Copy link
Contributor

@AntDavidLima AntDavidLima commented May 19, 2025

Pull Request Description

This pull request adds an icon to the right of the files, in the files app, showing the file signature status on the original and the signed files. The original will have the status 'Original file signed elsewhere' and the signed file will have the status 'Partially signed' and 'Signed', depending on the signing progress.

Before: After:
before after

To test the feature, after checking out to the pull request:

  • upload a PDF file to Nextcloud using the files app;
  • request the signature from two different users;
  • sign the file with one of the requested users;
  • the original file will show a green sign icon, with the text 'original file' when hovering over it;
  • the signed file will show a yellow ½ icon, with the text 'partially signed' when hovering over it;
  • now sign the file with the second requested user;
  • the signed file will show a blue sign icon, with the text 'signed' when hovering over it.

Related Issue

Issue Number: #4160

Pull Request Type

  • Feature

Pull request checklist

  • Did you explain or provide a way of how can we test your code ?
  • If your pull request is related to frontend modifications provide a print of before and after screen
  • Did you provide a general summary of your changes ?
  • Try to limit your pull request to one type, submit multiple pull requests if needed
  • I implemented tests that cover my contribution

@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap May 19, 2025
Copy link

welcome bot commented May 19, 2025

Thanks for opening your first pull request in this repository! ✌️

@AntDavidLima AntDavidLima marked this pull request as draft May 19, 2025 14:22
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 1. to do in Roadmap May 22, 2025
@vitormattos vitormattos marked this pull request as ready for review May 23, 2025 19:17
@vitormattos vitormattos marked this pull request as draft May 23, 2025 19:17
@vitormattos vitormattos moved this from 1. to do to 2. in progress in Roadmap Jul 9, 2025
@github-project-automation github-project-automation bot moved this from 2. in progress to 4. to release in Roadmap Jul 21, 2025
@vitormattos
Copy link
Member

vitormattos commented Jul 21, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants