feat: implement TSA #5423
Draft
feat: implement TSA #5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
force-pushed
the
feat/implement-tsa
branch
from
87cce3b to
f3191b1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements TSA (Timestamp Authority) support for digital signatures, allowing documents to be timestamped during signing for better authentication and non-repudiation.
- Adds TSA configuration in admin settings with hardcoded FreeTSA server URL
- Integrates timestamp extraction and display in signature validation
- Updates signing engines to include TSA server configuration and timestamp data parsing
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/features/sign/signed.feature | Adds test configuration for TSA URL setting |
| src/views/Validation.vue | Displays timestamp information in signature validation UI |
| src/views/Settings/TSA.vue | New admin settings component for TSA configuration |
| src/views/Settings/Settings.vue | Integrates TSA settings component |
| lib/Service/FileService.php | Formats timestamp data for frontend display |
| lib/Handler/SignEngine/TSA.php | New TSA handler for timestamp extraction and parsing |
| lib/Handler/SignEngine/Pkcs12Handler.php | Integrates TSA timestamp extraction in certificate chain processing |
| lib/Handler/SignEngine/JSignPdfHandler.php | Adds TSA server URL parameter to PDF signing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| if ($type !== null && isset($n['content']) && is_string($n['content'])) { | ||
| $txt = $n['content']; | ||
| if (@preg_match('//u', $txt) && preg_match('/[\P{C}]/u', $txt)) { |
There was a problem hiding this comment.
The first preg_match has an empty pattern '//', which will likely cause a warning or error. This should be removed or replaced with a valid UTF-8 validation pattern.
Suggested change
| if (@preg_match('//u', $txt) && preg_match('/[\P{C}]/u', $txt)) { | |
| if (preg_match('/./u', $txt) && preg_match('/[\P{C}]/u', $txt)) { |
Copilot uses AI. Check for mistakes.
Was used a hardcoded TSA server and without authentication for now Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
solve #5423 (comment) Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
feat/implement-tsa
branch
from
f3191b1 to
bb5f0d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was used a hardcoded TSA server and without authentication for now.
Validation page:
Administration settings: