feat: sign usign twofactor_gateway #5459

vitormattos · 2025-09-22T19:02:21Z

Objective

Allow requesting a document signature by adding a WhatsApp number (or another configured gateway) and sending the signing link directly to this number.

⚠️ For WhatsApp, this implementation uses WhatsApp Web and not the WhatsApp Business API.

How to test

Install the twofactor_gateway app.
- For now will be necessary to use the master branch of this app.
Configure a gateway (e.g., WhatsApp or SMS).
Go to LibreSign Administration Settings.
Enable the signature method related to the configured provider in Twofactor Gateway.
- Only the providers that are configured will appear as signature methods.
Follow the usual steps to request a document signature.

Administration settings

Only the gateways configured in the Twofactor Gateway app will be visible.

Sign request flow

The Add signer screen has been improved for a better UX and now is a dialog.
Signature methods are now organized into tabs.
Only the identity methods enabled in Administration Settings will be shown.

👉 Don’t worry about the number of tabs, in most scenarios there will be no more than three. For demonstration purposes, all available methods were enabled to show compatibility with multiple signature request options.

The chosen signature method will now appear as a label under the signer’s name.

After finishing the sign request flow, the signer will receive the signing link via the selected service:

To-do

Implement unit tests
Implement integration tests
Add a new gateway to sign with Telegram at Twofactor Gateway but now using the client API of Telegram

Signed-off-by: Vitor Mattos <[email protected]>

Solve #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

Signed-off-by: Vitor Mattos <[email protected]>

At context of LibreSign search, the field shareType need to be the sign method. Signed-off-by: Vitor Mattos <[email protected]>

only is valid if the result have a method and the method is not empty Signed-off-by: Vitor Mattos <[email protected]>

fix #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

Signed-off-by: Vitor Mattos <[email protected]>

fix: #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

Signed-off-by: Vitor Mattos <[email protected]>

AntDavidLima · 2025-09-23T18:05:16Z

lib/Controller/FileController.php

 	 * Send a file
 	 *
-	 * Send a new file to Nextcloud and return the fileId to request to sign usign fileId
+	 * Send a new file to Nextcloud and return the fileId to request to signature


Suggested change

* Send a new file to Nextcloud and return the fileId to request to signature

* Send a new file to Nextcloud and return the fileId to request signature

AntDavidLima · 2025-09-23T18:11:46Z

lib/Controller/IdentifyAccountController.php

 	}

 	private function formatForNcSelect(array $list): array {
+		$return = [];


$return doesn't sound very descriptive, maybe $formattedList would be better.

vitormattos added this to the Next Major (33) milestone Sep 22, 2025

vitormattos requested a review from Copilot September 22, 2025 19:02

vitormattos self-assigned this Sep 22, 2025

github-project-automation bot added this to Roadmap Sep 22, 2025

github-project-automation bot moved this to 0. Needs triage in Roadmap Sep 22, 2025

This comment was marked as resolved.

Sign in to view

vitormattos force-pushed the feat/sign-using-twofactor_gateway branch from 0b14fe3 to 63f7d9c Compare September 22, 2025 20:39

vitormattos requested a review from Copilot September 22, 2025 20:39

This comment was marked as resolved.

Sign in to view

vitormattos requested a review from Copilot September 22, 2025 21:26

This comment was marked as resolved.

Sign in to view

vitormattos added 19 commits September 22, 2025 19:34

chore: stop search early if haven't values to search for

80e9a7f

Signed-off-by: Vitor Mattos <[email protected]>

feat: Search by signers

5598b8c

Signed-off-by: Vitor Mattos <[email protected]>

fix: add pendign param

721e7e3

Signed-off-by: Vitor Mattos <[email protected]>

chore: update openapi

49325a8

Signed-off-by: Vitor Mattos <[email protected]>

fix: remove todo and fix method to use twofactor_gateway

b6a1fc3

Signed-off-by: Vitor Mattos <[email protected]>

chore: remove direct access to property and implement getter

9f31207

Signed-off-by: Vitor Mattos <[email protected]>

fix: don't return not allowed settings

9dee22c

Signed-off-by: Vitor Mattos <[email protected]>

chore: add setter and getter to name

618feda

Signed-off-by: Vitor Mattos <[email protected]>

fix: make more generic

6ed2ae4

Signed-off-by: Vitor Mattos <[email protected]>

feat: change way to add a signer, use a modal to be possible split

c46471c

Signed-off-by: Vitor Mattos <[email protected]>

chore: add signal svg

3da5031

Signed-off-by: Vitor Mattos <[email protected]>

fix: cs

5096129

Signed-off-by: Vitor Mattos <[email protected]>

feat: send twofactor_gateway notification

6e4ae67

Signed-off-by: Vitor Mattos <[email protected]>

feat: implement gateways

939c639

Signed-off-by: Vitor Mattos <[email protected]>

fix: psalm

ace3a36

Signed-off-by: Vitor Mattos <[email protected]>

fix: copy paste code, added real code

72a4acb

Signed-off-by: Vitor Mattos <[email protected]>

fix: psalm update baseline

91d6dd7

Signed-off-by: Vitor Mattos <[email protected]>

fix: send code to sign

20ba69d

Signed-off-by: Vitor Mattos <[email protected]>

fix: linter

75cd9ad

Signed-off-by: Vitor Mattos <[email protected]>

vitormattos added 6 commits September 22, 2025 22:39

chore: resolve code review comment

b41bb04

Solve #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

fix: only consider the search item when have a method

501a139

Signed-off-by: Vitor Mattos <[email protected]>

fix: validate the email address when is searching by account

dcca860

Signed-off-by: Vitor Mattos <[email protected]>

chore: indent code

aba92b9

Signed-off-by: Vitor Mattos <[email protected]>

fix: typo

73814be

Signed-off-by: Vitor Mattos <[email protected]>

chore: replace shareType by method

c8c593f

At context of LibreSign search, the field shareType need to be the sign method. Signed-off-by: Vitor Mattos <[email protected]>

vitormattos requested a review from Copilot September 23, 2025 11:32

This comment was marked as resolved.

Sign in to view

fix: filter valid condition

08f6dda

only is valid if the result have a method and the method is not empty Signed-off-by: Vitor Mattos <[email protected]>

vitormattos requested a review from Copilot September 23, 2025 11:48

This comment was marked as resolved.

Sign in to view

vitormattos added 6 commits September 23, 2025 09:00

fix: code review

b244d4f

fix #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

fix: code review

548a39a

fix #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

fix: code review

62e81b9

fix #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

fix: previous change was wrong

5a22bd0

Signed-off-by: Vitor Mattos <[email protected]>

fix: openapi

889003c

Signed-off-by: Vitor Mattos <[email protected]>

fix: prevent warning when haven't an email

610eb24

Signed-off-by: Vitor Mattos <[email protected]>

vitormattos requested review from Any97Cris, AntDavidLima and Copilot September 23, 2025 13:47

This comment was marked as resolved.

Sign in to view

vitormattos added 6 commits September 23, 2025 11:00

fix: the method key was removed and I added back

4833fbb

Signed-off-by: Vitor Mattos <[email protected]>

fix: the match syntax was incorrect

5fdcf43

Signed-off-by: Vitor Mattos <[email protected]>

fix: enlarge the dialog size

1160db3

Signed-off-by: Vitor Mattos <[email protected]>

chore: use a more readdable code

3e4fcd8

fix: #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

chore: replace string svg by a real file

b7412c0

fix: #5459 (comment) Signed-off-by: Vitor Mattos <[email protected]>

fix: psalm update baseline

81c4ad1

Signed-off-by: Vitor Mattos <[email protected]>

AntDavidLima requested changes Sep 23, 2025

View reviewed changes

github-project-automation bot moved this from 0. Needs triage to 1. to do in Roadmap Sep 23, 2025

Any97Cris approved these changes Sep 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: sign usign twofactor_gateway #5459

feat: sign usign twofactor_gateway #5459

Uh oh!

vitormattos commented Sep 22, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

AntDavidLima Sep 23, 2025

Uh oh!

AntDavidLima Sep 23, 2025

Uh oh!

Uh oh!

	* Send a new file to Nextcloud and return the fileId to request to signature
	* Send a new file to Nextcloud and return the fileId to request signature

Uh oh!

feat: sign usign twofactor_gateway #5459

Are you sure you want to change the base?

feat: sign usign twofactor_gateway #5459

Uh oh!

Conversation

vitormattos commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

How to test

Administration settings

Sign request flow

To-do

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

AntDavidLima Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

AntDavidLima Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vitormattos commented Sep 22, 2025 •

edited

Loading