glibc/rawposix - writev/iovec fix #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennergade
changed the title
rennergade
reviewed
Aug 20, 2025
|
Also needs to pass linter |
rennergade
reviewed
Aug 27, 2025
| ssize_t | ||
| __writev (int fd, const struct iovec *iov, int iovcnt) | ||
| { | ||
| // clean up padding field of each iovec |
Yaxuan-w
reviewed
Aug 27, 2025
| translate_vmmap_addr(&cage, arg2).unwrap() as *const IovecStruct; | ||
| // iterate through each iovec pointer and manually do the address conversion | ||
| for i in 0..iovcnt { | ||
| let cur_iov_base = unsafe { iov_base.add(i as usize) } as *mut libc::iovec; |
There was a problem hiding this comment.
Why we don't use current type casting function?
|
@ssannkkallpp these fixes should just be wrapped into the address PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the fix for writev syscall and iovec struct
Since
iovechas addresses inside its struct, it becomes a little tricky to handle it correctly in lind. One padding fields is added below to each address field to resolve the issue of 32-bit address and 64-bit address. Therefore, the padding fields also needs to be cleaned up before sending to the rawposix