glibc - fix spawni #360
Open
glibc - fix spawni #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qianxichen233 All of the comments here need to explain why these things were removed |
rennergade
reviewed
Oct 14, 2025
| int prot = (PROT_READ | PROT_WRITE | ||
| | ((GL (dl_stack_flags) & PF_X) ? PROT_EXEC : 0)); | ||
| // lind-wasm: disallow PROC_EXEC | ||
| int prot = (PROT_READ | PROT_WRITE); |
There was a problem hiding this comment.
this probably should fall through to rawposix where we can lind_panic_debug
There was a problem hiding this comment.
explain why if we wont remove
rennergade
reviewed
Oct 20, 2025
| where it might use about 1k extra stack space). */ | ||
| argv_size += (32 * 1024); | ||
| size_t stack_size = ALIGN_UP (argv_size, GLRO(dl_pagesize)); | ||
| // lind-wasm: remove MAP_STACK |
rennergade
reviewed
Oct 20, 2025
| | CLONE_CLEAR_SIGHAND | ||
| | CLONE_VM | ||
| | CLONE_VFORK, | ||
| | CLONE_VFORK, // lind-wasm: removed CLONE_VM flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the fix for
spawnifunction.spawnifunction is used bypopen. These are some changes made to makepopenbe able to run under lind's environment