fix: touch scaling bug and initialize display variables as 0#4758
Draft
ReenigneArcher wants to merge 1 commit intomasterfrom
Draft
fix: touch scaling bug and initialize display variables as 0#4758ReenigneArcher wants to merge 1 commit intomasterfrom
ReenigneArcher wants to merge 1 commit intomasterfrom
Conversation
Bundle ReportBundle size has no change ✅ |
ReenigneArcher
force-pushed
the
fix/double-offset
branch
from
8510c4a to
5aed1e9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4758 +/- ##
=========================================
Coverage ? 15.39%
=========================================
Files ? 97
Lines ? 20674
Branches ? 9472
=========================================
Hits ? 3183
Misses ? 13814
Partials ? 3677
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ReenigneArcher
force-pushed
the
fix/double-offset
branch
3 times, most recently
from
f242ef3 to
619caf9
Compare
Initialize additional display_t members (env_width/env_height/env_logical_width/env_logical_height/width/height/logical_width/logical_height) in the constructor to ensure consistent defaults. Fix touch input scaling on Windows by removing a redundant addition of display offsets (preventing double-offsetting for multi-monitor setups) and adding a clarifying comment. Tighten the video coordinate check to use explicit >0 comparisons for logical/env sizes before computing scaling factors. Co-Authored-By: Chase Payne <27069224+nonary@users.noreply.github.com>
ReenigneArcher
force-pushed
the
fix/double-offset
branch
from
619caf9 to
80a272c
Compare
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize additional display_t members (env_width/env_height/env_logical_width/env_logical_height/width/height/logical_width/logical_height) in the constructor to ensure consistent defaults. Fix touch input scaling on Windows by removing a redundant addition of display offsets (preventing double-offsetting for multi-monitor setups) and adding a clarifying comment. Tighten the video coordinate check to use explicit >0 comparisons for logical/env sizes before computing scaling factors.
TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage