Skip to content

style(cpp): separate multiple variable declarations#4795

Open
ReenigneArcher wants to merge 1 commit intomasterfrom
style/separate-multiple-variable-declarations
Open

style(cpp): separate multiple variable declarations#4795
ReenigneArcher wants to merge 1 commit intomasterfrom
style/separate-multiple-variable-declarations

Conversation

@ReenigneArcher
Copy link
Member

Description

Resolves sonar warning. Multiple variables should not be declared on the same line cpp:S1659

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the style/separate-multiple-variable-declarations branch 3 times, most recently from 5e12fa3 to be2992b Compare March 1, 2026 02:38
@ReenigneArcher ReenigneArcher force-pushed the style/separate-multiple-variable-declarations branch from be2992b to 74f1133 Compare March 1, 2026 02:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2026

@ReenigneArcher ReenigneArcher added this to the sonar milestone Mar 1, 2026
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.35%. Comparing base (2b7af21) to head (74f1133).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/misc.cpp 0.00% 8 Missing ⚠️
src/crypto.cpp 40.00% 6 Missing ⚠️
src/platform/linux/vaapi.cpp 0.00% 4 Missing ⚠️
src/platform/windows/input.cpp 0.00% 3 Missing ⚠️
src/input.cpp 0.00% 2 Missing ⚠️
src/platform/linux/graphics.cpp 0.00% 2 Missing ⚠️
src/platform/linux/kmsgrab.cpp 0.00% 2 Missing ⚠️
src/platform/linux/wlgrab.cpp 0.00% 2 Missing ⚠️
src/platform/windows/display.h 0.00% 2 Missing ⚠️
src/stream.cpp 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
+ Coverage   15.34%   15.35%   +0.01%     
==========================================
  Files          97       97              
  Lines       20631    20647      +16     
  Branches     9452     9453       +1     
==========================================
+ Hits         3166     3171       +5     
+ Misses      15318    14759     -559     
- Partials     2147     2717     +570     
Flag Coverage Δ
Archlinux 11.07% <16.66%> (+<0.01%) ⬆️
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.07% <16.66%> (+<0.01%) ⬆️
Homebrew-ubuntu-22.04 13.27% <15.38%> (+<0.01%) ⬆️
Linux-AppImage 11.48% <15.38%> (+<0.01%) ⬆️
Windows-AMD64 13.43% <16.00%> (+<0.01%) ⬆️
Windows-ARM64 12.36% <14.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/input.h 0.00% <ø> (ø)
src/platform/common.h 29.52% <ø> (ø)
src/platform/linux/cuda.cpp 1.80% <ø> (ø)
src/platform/linux/cuda.h 0.00% <ø> (ø)
src/platform/linux/graphics.h 0.00% <ø> (ø)
src/platform/windows/display_vram.cpp 10.31% <ø> (ø)
src/video.h 61.46% <ø> (ø)
src/video_colorspace.cpp 24.44% <ø> (ø)
src/input.cpp 0.11% <0.00%> (-0.01%) ⬇️
src/platform/linux/graphics.cpp 2.51% <0.00%> (-0.01%) ⬇️
... and 9 more

... and 50 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant