Skip to content

Use per-second instead of per-tick times #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use per-second instead of per-tick times #64

wants to merge 4 commits into from

Conversation

@nabijaczleweli
Copy link
Member

@nabijaczleweli nabijaczleweli commented Apr 25, 2016

Closes #63

@nabijaczleweli nabijaczleweli added this to the V1 milestone Apr 25, 2016
@TheCatPlusPlus
Copy link
Member

TheCatPlusPlus commented Apr 25, 2016

The problem with this is that the framerate is not guaranteed to be constant, hence why requestAnimationFrame callback gives you a timestamp and why the stub had a delta calculation which was supposed to be used for this. The server needs something like that, too. Multiplying real time values by a constant is only really valid when time step is fixed (but you still need real time deltas to know how many times to update physics in a frame), otherwise they should be multiplied by the real time delta.

@nabijaczleweli
Copy link
Member Author

nabijaczleweli commented Apr 25, 2016 •
edited
Loading

I guess timestamps in Game.frame are respected now?
If that's not it I'm not quite sure what you're on about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

client feature server

Projects

None yet

Milestone

V1

Development

Successfully merging this pull request may close these issues.

3 participants

@nabijaczleweli @TheCatPlusPlus