Skip to content

Conversation

@j-rafique
Copy link
Contributor

No description provided.

@roomote
Copy link

roomote bot commented Feb 6, 2026

Rooviewer Clock   See task

Reviewed the latest changes (95710fc). The refactoring from audit_reporter to host_reporter and the API renames look good. No new issues found in this update.

  • Case-sensitive proof hash comparison in VerifySliceProof handler could cause false negatives if hex characters arrive in uppercase
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Comment on lines +94 to +95
want := req.ProofHashHex
got := hex.EncodeToString(sum[:])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proof hash comparison here is case-sensitive, but the challenger in service.go:315 normalizes to lowercase with strings.ToLower(resp.ProofHashHex). If a proof hash arrives with uppercase hex characters (e.g., from a different implementation or modified response), this comparison will fail even though the hashes are semantically equal. Consider normalizing both sides to lowercase for consistency:

Suggested change
want := req.ProofHashHex
got := hex.EncodeToString(sum[:])
want := strings.ToLower(req.ProofHashHex)
got := hex.EncodeToString(sum[:])

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant