- 
                Notifications
    You must be signed in to change notification settings 
- Fork 79
feat: batched_jacobian for Reactant #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Summary of ChangesHello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the automatic differentiation capabilities by integrating  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for batched_jacobian with the Reactant.jl backend. The implementation for both forward and reverse modes using Enzyme is added in a new file. The changes also include refactoring of some Enzyme-related utility functions into a central utils.jl module and cleaning up the batched_jacobian API definitions. The overall changes are well-structured and improve the codebase. I've found one critical issue where a function was renamed/moved, but one of its usages was not updated, which will lead to a runtime error.
f406fa6    to
    a26ef48      
    Compare
  
    | Codecov Report❌ Patch coverage is  
 
 Additional details and impacted files@@             Coverage Diff             @@
##             main    #1507       +/-   ##
===========================================
- Coverage   82.79%   16.78%   -66.01%     
===========================================
  Files         168      156       -12     
  Lines        6939     6784      -155     
===========================================
- Hits         5745     1139     -4606     
- Misses       1194     5645     +4451     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Benchmark Results (Julia v1.11)Time benchmarks
 Memory benchmarks
 | 
a26ef48    to
    ef7f2f5      
    Compare
  
    
Uh oh!
There was an error while loading. Please reload this page.