Skip to content

Correct rosdistro keys #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2020
Merged

Correct rosdistro keys #32

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fe9ff8
Update package.xml
ruffsl Jan 9, 2020
47b2b99
Correct depend names
ruffsl Jan 9, 2020
67d87e1
Merge branch 'master' into patch-3
ToniRV May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,15 @@

<buildtool_depend>cmake</buildtool_depend>

<depend>KimeraRPGO</depend>
<depend>GTSAM</depend>
<depend>gflags</depend>
<depend>glog</depend>
<depend>opencv</depend>
<depend>opengv</depend>
<depend>dbow2</depend>
<depend>gtsam</depend>
<depend>kimera_rpgo</depend>
Copy link
Collaborator

@ToniRV ToniRV Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ok, as I think it is KimeraRPGO, we should make a PR to the RPGO repo updating the name there.

Copy link
Contributor Author

@ruffsl ruffsl Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See MIT-SPARK/Kimera-RPGO#45

<depend>libgflags-dev</depend>
<depend>libgoogle-glog-dev</depend>
Copy link
Collaborator

@ToniRV ToniRV Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two above are irrelevant actually because we use cmake files to find glog/gflags as I had tons of issues with these two in multiple systems...

Copy link
Contributor Author

@ruffsl ruffsl Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use cmake files to find glog/gflags

Not sure being explicit about this external dependency the manifest would change what the CMake does to find the glog/gflags installed in the cmake path. Are you saying that the system install of glog/gflags in the latest ubuntu LTS is still an issue?

<depend>libopencv-dev</depend>
Copy link
Collaborator

@ToniRV ToniRV Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, should be opencv or rather opencv3_catkin if we use ETH's catkinized opencv3

Copy link
Collaborator

@ToniRV ToniRV Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use libopencv-dev, what are we assuming? That ppl installed opencv how?

Copy link
Contributor Author

@ruffsl ruffsl Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct/official rosdep key name for the opencv3 library:

https://github.com/ros/rosdistro/blob/4bfca115e18c733686b3b39524fbf1e227177574/rosdep/base.yaml#L2815

By declaring the same key name as the dependency, users with other packages depending on opencv3 don't have to monkey patch there manifest to use the same key to avoid rosdep from installing libopencv-dev from apt repo if the kimera workspace it builds from already includes a source build of opencv.

Note how this is used in the Dockerfile that builds the underlay for the ros wrapper:
https://github.com/MIT-SPARK/Kimera-VIO-ROS/pull/32/files#diff-3254677a7917c6c01f55212f86c57fbfR71-R95

<depend>opengv</depend>
<export>
<!-- Specify that this is not really a catkin package-->
<build_type>cmake</build_type>
</export>
</package>