Merged
Conversation
Single llc face
Member
|
@IvanaEscobar thanks for that! The CI tests are all passing now and we should merge this PR as soon as possible, so that other PRs can be tested and moved forward. This is a big step forward! As I am no expert (neither python, CI, nor xmitgcm), I can only work on obvious bug fixes. I will merge this tomorrow, if there are no objections. |
Member
|
also fixes issue #345 |
Member
|
@IvanaEscobar do you have anything else to add, or should I try to merge this now? |
Contributor
Author
|
@mjlosch it's ready for merging |
Member
|
@IvanaEscobar
is that this valid after the lastest 3 commits? |
Contributor
Author
|
Good catch, I updated the description to remove that note. Codecov works as long as there is a token provided as an Action Secret. |
This was referenced Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates CI for Python versions 3.11, 3.12, and 3.13:
v2/3 --> v4zarrversion, othertest_envversionsversioneerand putsetuptools-scmin place