Adding llcreader ASTE model on TACC featuring snapshots#358
Open
mgoldberg10 wants to merge 2 commits intoMITgcm:masterfrom
Open
Adding llcreader ASTE model on TACC featuring snapshots#358mgoldberg10 wants to merge 2 commits intoMITgcm:masterfrom
mgoldberg10 wants to merge 2 commits intoMITgcm:masterfrom
Conversation
… lines within llcreader that were broken likely due to some updates to zarr Added unit tests for CRIOSTACCPortalASTE270Model
Contributor
|
@mjlosch , this PR needs approval from a maintainer (you) to check CI via GitHub. @mgoldberg10 , were you able to produce passing tests for the new ASTE access via |
Author
Yes I got the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antnguyen13 copied ASTE Release 1 output to TACC's Corral and included snapshot diagnostics for users interested in budget closures. This PR makes that model available through llcreader. I copied the structure of #231's
CRIOSPortalASTE270Modelhosted on AWS.I added the snapshot diagnostic names to
package_state_variablesbut am open to moving it to its own dictionary.I found I had to update two lines in llcmodel as well in order to access the existing llcreader ASTE models.
Added some unit tests, updated docs.