window type is changed to hamming in discontinuity detection.

[AhmetOguzOzturk]

In DiscontinuityDetector.cpp file, triangular window type is changed to Hamming, after the study of my master thesis.

[palonso]

Thank you for your contribution @AhmetOguzOzturk,

I tested the new behavior and found that testNoOverlap is not passing with the new window type. This means that the algorithm behaves worse under no-overlap conditions with the new window type. Since I can't think of a scenario where a non-overlapped analysis is particularly useful I propose the following changes:

• Explicitly recommend using half-overlapped frames in the algorithm documentation. We can add the following lines:

The recommended pipeline is as follows:

MonoLoader(sampleRate=16000, filename="audio.wav") >> FrameCutter(frameSize=512, hopSize=256, startFromZero=True) >> DiscontinuityDetector(frameSize=512, hopSize=256)

You can check this example.

• Remove the testNoOverlap, since we no longer recommend this type of analysis.

Any thoughts @dbogdanov ?

[dbogdanov]

If the frames should be always half-overlapped, why do we need the hopSize parameter?

[palonso]

Normally we use it with half-overlapped frames but the algorithm supports different amounts of overlap.

[dbogdanov]

I agree with your suggestions. We can either remove or update the expected ground truth for testNoOverlap.