Skip to content

Fix for get_pref_managed() when a temporary configuration is used #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tuttu wants to merge 3 commits into from
Closed

Fix for get_pref_managed() when a temporary configuration is used #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ed968
Update Jamf-Pro-External-Application-Custom-Schema-com.macjutsu.super…
tonyyo11 Oct 6, 2025
f67ec54
Merge pull request #320 from tonyyo11/5.1.0-rc1-JSONUpdate
Macjutsu Oct 6, 2025
eb2136a
fix: get_pref_managed now looks at the good file when a temporary wor…
Tuttu Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Example-MDM/Jamf-Pro-External-Application-Custom-Schema-com.macjutsu.super-v5.1.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@
}
},
"DisplayAccessorySafariUpdateFile": {
"title": "Non-System Updates Accessory File",
"title": "Safari Updates Accessory File",
"description": "Local path or http(s) URL to a file that is the accessory to display when the InstallSafariUpdateWithoutRestarting payload option is also enabled and the workflow target is only non-system updates. Put X to reset this to default.",
"type": "string",
"options": {
Expand Down
17 changes: 14 additions & 3 deletions super
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,11 +1133,22 @@ delete_pref() {
get_pref_managed() {
{ [[ "${config_edit_main_option}" == "TRUE" ]] || [[ -n "${config_edit_option}" ]] || [[ -n "${config_delete_option}" ]] || [[ "${config_delete_all_option}" == "TRUE" ]]; } && return 1
local preference_result
{ [[ -f "${SUPER_MANAGED_PLIST}.plist" ]] && [[ -n "${alternate_temporary_plist}" ]] && [[ "${config_temp_override}" == "TRUE" ]]; } && preference_result=$(defaults read "${super_alternate_plist}" "${1}" 2>/dev/null)
{ [[ -f "${SUPER_MANAGED_PLIST}.plist" ]] && [[ -z "${preference_result}" ]]; } && preference_result=$(defaults read "${SUPER_MANAGED_PLIST}" "${1}" 2>/dev/null)
local source_plist
if [[ -f "${SUPER_MANAGED_PLIST}.plist" ]] && [[ -n "${alternate_temporary_plist}" ]] && [[ "${config_temp_override}" == "TRUE" ]]; then
preference_result=$(defaults read "${super_alternate_plist}" "${1}" 2>/dev/null)
if [[ -n "${preference_result}" ]]; then
source_plist="${super_alternate_plist}"
fi
fi
if [[ -f "${SUPER_MANAGED_PLIST}.plist" ]] && [[ -z "${preference_result}" ]]; then
preference_result=$(defaults read "${SUPER_MANAGED_PLIST}" "${1}" 2>/dev/null)
if [[ -n "${preference_result}" ]]; then
source_plist="${SUPER_MANAGED_PLIST}"
fi
fi
if [[ -n "${preference_result}" ]]; then
local preference_type
preference_type=$(defaults read-type "${SUPER_MANAGED_PLIST}" "${1}" 2>/dev/null)
preference_type=$(defaults read-type "${source_plist}" "${1}" 2>/dev/null)
if [[ $(echo "${preference_type}" | grep -c 'boolean') -gt 0 ]]; then
{ [[ "${preference_result}" == "0" ]] || [[ "${preference_result}" == "FALSE" ]]; } && echo "FALSE" && return 0
{ [[ "${preference_result}" == "1" ]] || [[ "${preference_result}" == "TRUE" ]]; } && echo "TRUE" && return 0
Expand Down