Prevent open if user scrolls 40+ pixels before initiating slide#73
Open
jrunge wants to merge 1 commit intoMango:masterfrom
Open
Prevent open if user scrolls 40+ pixels before initiating slide#73jrunge wants to merge 1 commit intoMango:masterfrom
jrunge wants to merge 1 commit intoMango:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was really frustrating when using the plugin in an app setting. If the user scrolled quickly and their thumb/finger moved more than 20px to the right, the slider would open.
The y threshold might need to be tweaked, but this seemed to work well in my testing.