Skip to content

MDBF-1195: Define C/ODBC ASAN/UBSAN builders#938

Open
RazvanLiviuVarzaru wants to merge 3 commits intoMariaDB:devfrom
RazvanLiviuVarzaru:odbc-asan-ubsan
Open

MDBF-1195: Define C/ODBC ASAN/UBSAN builders#938
RazvanLiviuVarzaru wants to merge 3 commits intoMariaDB:devfrom
RazvanLiviuVarzaru:odbc-asan-ubsan

Conversation

@RazvanLiviuVarzaru
Copy link
Copy Markdown
Collaborator

@grooverdan
Copy link
Copy Markdown
Member

I know its migration but there's a chance to improve the situation:

  • ASAN and UBSAN can be instrumented together in the same builder like the server
  • gcc is a older and more limited ASAN/UBSAN, tested with the msan-clang-22 container and on the ODBC side anyway - there's ODBC-489 and CONC-813.
  • the compiler itself highlight a number of warnings not visible by gcc

The code fixes for these failures aren't extreme, so we could make the block MDBF-1195.

I haven't yet run the pure C/C test on ASAN/UBSAN clang-22.

@RazvanLiviuVarzaru
Copy link
Copy Markdown
Collaborator Author

Right! I knew you are the go to person on asan/ubsan, thanks for opening the discussion on improvements!
Let's see what Lawrin has to say about.

@grooverdan
Copy link
Copy Markdown
Member

grooverdan commented Mar 29, 2026

Did test C/C directly - found additionally - CONC-814 - not relevant for this PR however.

note env for the CI env:

export UBSAN_OPTIONS=print_stacktrace=1:report_error_type=1:halt_on_error=1
export ASAN_OPTIONS=detect_stack_use_after_return=1:detect_leaks=1:abort_on_error=1:atexit=0:detect_invalid_pointer_pairs=3:dump_instruction_bytes=1:allocator_may_return_null=1

Copy link
Copy Markdown
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@RazvanLiviuVarzaru
Copy link
Copy Markdown
Collaborator Author

As the name suggests, 9c5086e, is just a draft, suppressions won't be hard-coded in Buildbot, should be in the upstream. The list is showing what is required to make the builder green, doesn't mean it is correct to suppress all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants