-
-
Notifications
You must be signed in to change notification settings - Fork 2k
MDEV-38195: Fix flaky events_restart test #4753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
varundeepsaini
wants to merge
1
commit into
MariaDB:11.8
from
varundeepsaini:MDEV-38195-fix-flaky-tests
+2
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varundeepsaini have you actually been able to reproduce this problem?
How did you come to conclusion that the problem is due to "corrupted
mysql.eventtable (body column altered to longtext during the test)"?If suspected
alter"corrupts"mysql.eventtable, why the problem is sporadic, not persistent?From what I can see
alteryou're referring to is executed in the middle of the test and it gets restored byrename table event_like to mysql.event. But event in questiontest.evis only created at the end of the test. There're many other events created in between and they don't fall victim to this corruption.