Add image specification to cloud-push #34611
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow images such as balancer or orchestratord to be specified in cloud push. This is useful for cloud personal stacks and self-managed deploys.
jubrad
force-pushed
the
cloud-push-balancer
branch
from
4d5e724 to
1620fde
Compare
def-
approved these changes
Dec 23, 2025
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
I haven't used this script, so I'm not sure I'm the best reviewer.
| shift | ||
| ;; | ||
| "-i"|"--image") | ||
| IMAGES+="$2 " |
Contributor
There was a problem hiding this comment.
not ideal that we just use spaces (and then later split by space), maybe an array instead.
| while [ "$#" -gt 0 ]; do | ||
| case "$1" in | ||
| "-u"|"--username") | ||
| USERNAME="$2" |
Contributor
There was a problem hiding this comment.
Most shell scripts are using lowercase variables I think. I don't mind either, but now it's more mixed in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow images such as balancer or orchestratord
to be specified in cloud push. This is useful for cloud personal stacks and self-managed deploys.
Motivation
I want an easier way to push up orchestratord and balancer images. This does have an issue with self-managed where we're not buliding console images so we can't actually push those and the console will break unless we specify an already pushed image in the MZ spec, but it helps test balancer changes a bit.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.