Merged
Conversation
…der (use registry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes related to permissions, item flag handling, and trim configuration loading in the menu system. The main themes are enhanced permission granularity, improved error handling and logging for trim patterns/materials, and safer flag parsing.
Permission and Command Improvements:
ZMENU_GIVE_OPEN_ITEM,ZMENU_EDITOR,ZMENU_VERSION) and removed the oldZMENU_OPEN_ITEMto provide more granular control over command access. Commands such asCommandMenuEditor,CommandMenuGiveOpenItem, andCommandMenuVersionnow require the appropriate new permissions. [1] [2] [3] [4] [5]Item Flag Handling:
MenuItemStackLoaderto ignore null flags, preventing potential errors when loading item flags from configuration.ZMenuItemStackfor applying item flags by removing unnecessary null checks, as nulls are now filtered earlier.Trim Pattern and Material Loading:
RegistryandNamespacedKeyAPIs directly, removing the dependency onTrimHelper. This change adds robust error handling and logs available patterns/materials if a lookup fails, improving debuggability and user feedback.Code Cleanup:
These changes collectively improve the maintainability, usability, and reliability of the menu system, especially regarding permissions and item customization.