Enchant open-with-item action#233
Merged
1robie merged 1 commit intoMaxlego08:developfrom Mar 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
ClickActionenum to centralize and simplify the handling of click actions, and refactors the logic for loading click actions from configuration files in theInventoryLoaderclass. The changes improve code maintainability, make action mapping more flexible, and add better error handling and debugging information.Refactoring and code improvements:
ClickActionenum infr.maxlego08.menu.api.utilsto group related BukkitActionvalues and provide a convenient method for retrieving associated actions.InventoryLoaderto use the newClickActionenum when parsing click actions from configuration, replacing direct use ofAction.valueOfwithClickAction.valueOf(...).asActions(). This allows for more flexible and robust mapping of configuration strings to actions.Error handling and debugging:
InventoryLoaderby logging a warning message when an invalid click action is encountered in the configuration, including the file path for easier debugging.Code cleanup:
InventoryLoaderby consolidating multiple import statements into a single wildcard import for utility classes.ClickActionenum inInventoryLoader.…entoryLoader