Uncrustify warnings #8522
Closed
Uncrustify warnings #8522
+38
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We know that using a different version of uncrustify produces different results. So make that an error rather than a warning. Also make the error output more helpful if uncrustify is not found. Signed-off-by: Gilles Peskine <[email protected]>
This makes it easier to run the script on a machine where the system-installed uncrustify is a different version. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
Contributor
minosgalanakis
left a comment
minosgalanakis
left a comment
There was a problem hiding this comment.
Looks good overall, with a minor tibit.
| stderr=subprocess.PIPE) | ||
| return str(output, "utf-8").strip() | ||
| except FileNotFoundError: | ||
| sys.stderr.write('Fatal: command {} not found in PATH.\n' |
Contributor
There was a problem hiding this comment.
This is a very nice practise.
| if args.fix: | ||
| # Fix mode | ||
| return fix_style(src_files) | ||
| return fix_style(args.uncrustify, src_files) |
Contributor
Contributor
Author
There was a problem hiding this comment.
UNCRUSTIFY_EXE shouldn't exist anymore... But I missed an occurrence. I'll fix that.
gilles-peskine-arm
added
needs-work
and removed
needs-review
Before this commit, verify mode still hard-coded "uncrustify" as the command name. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
Ryan-Everett-arm
added
the
needs-backports
yuhaoth
removed
the
needs-reviewer
Contributor
Author
|
Most of the affected code is now in the framework, so I raised a new pull request there: Mbed-TLS/mbedtls-framework#233 The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
scripts/code_style.pyeasier to use by occasional contributors. In particular, insist on the version we require. Currently we have a warning but people ignore warnings.PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")