Skip to content

Conversation

@Ujstor
Copy link
Collaborator

@Ujstor Ujstor commented Dec 16, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem

close #339

Description of Changes:

As described in the linked issue, we should not use Node for serving static assets.

Checklist

@valxntine
Copy link

Just out of curiosity - is there any plans to expand this functionality? I'd typically reach for Caddy rather than nginx, for example. There are also other options such as Envoy which I currently use at work. Are we against turning this into a flag and having a few options for the user? (in the future, not suggesting a re-write of this PR)

@Ujstor
Copy link
Collaborator Author

Ujstor commented Jan 21, 2025

@valxntine This is a great idea, and it could be done when we are redesigning the CLI. Frontend stuff will have a separate flag, and we can expand advanced flags when Docker and frontend are paired. Caddy and Traefik with automatic SSL are something that I would like to see implemented.

@Ujstor Ujstor marked this pull request as draft January 30, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Golang to Serve Frontend Assets (like React) instead of Node.Js

3 participants