Tested the fix done by Nan of the issue #87 regarding n & pct display… #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in format_ae_forestly
wangben718
reviewed
Aug 27, 2025
| # expect_named(ae_frm, c("n", "prop", "total")) | ||
| expect_named(ae_frm) | ||
| expect_true("diff" %in% names(ae_frm)) | ||
| expect_false("total" %in% names(ae_frm)) |
Collaborator
There was a problem hiding this comment.
Hi @lm3388 , why is it expecting False for "total"?
Collaborator
Author
There was a problem hiding this comment.
It is correct that the 'ae_frm' list does not have "total" element. The "total" actually exists inside the "display" element of 'ae_frm', which I think is by design. The test code has been updated in accordance with this set. Thank you!
wangben718
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the function with expected results with or without 'n', 'prop' in the display parameter