Fix sim_gs_n to provide updated efficacy bound when it is one-sided test
#349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
reviewed
Oct 15, 2025
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
Suggested alternative:
if (all(original_design$bound$bound == "upper")) {
setnames(planned_bounds, c("analysis", "planned_upper_bound"))
} else {
setnames(planned_bounds, c("analysis", "planned_lower_bound", "planned_upper_bound"))
}
jdblischak
approved these changes
Oct 15, 2025
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
I recommend adding a test with a 1-sided design that follows the new code path that this PR introduces
LittleBeannie
deleted the
348-fix-sim_gs_n-to-allow-updated-design-when-it-is-one-sided-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #348