-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: update error msgs #37748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: update error msgs #37748
+79
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +67 -47)
🔐 @MetaMask/web3auth (1 files, +67 -47)
|
arch1995
approved these changes
Nov 12, 2025
lionellbriones
approved these changes
Nov 12, 2025
Collaborator
Builds ready [49cd87b]
UI Startup Metrics (1203 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
cryptotavares
approved these changes
Nov 12, 2025
Collaborator
Builds ready [943bb72]
UI Startup Metrics (1190 ± 87 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [4ebd6bf]
UI Startup Metrics (1238 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [6736940]
UI Startup Metrics (1246 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-shield
release-13.10.0
Issue or pull request that will be included in release 13.10.0
size-M
team-web3auth
Web3Auth team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update error codes for shield rule engine
Changelog
CHANGELOG entry: Updated error codes for shield rule engine
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates Transaction Shield alert mappings (including new E800–E803 and tweaks to E007/E402) and adds locale strings for high-risk transactions and token warning.
getModalBodyStrmappings inui/pages/confirmations/hooks/alerts/useShieldCoverageAlert.ts:E800–E803(high-risk swap receiver, token warning, invalid sentinel results) with corresponding messages.E402toshieldCoverageAlertMessageTxTypeNotSupported.E007toshieldCoverageAlertMessageUnknown.shieldCoverageAlertHighRiskTransactionandshieldCoverageAlertMessageTokenTrustSignalWarningtoapp/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.Written by Cursor Bugbot for commit 6736940. This will update automatically on new commits. Configure here.