Skip to content

Conversation

noramibu
Copy link
Contributor

@noramibu noramibu commented Oct 4, 2025

Type of change

  • New feature

Description

  • Added food information
  • Books now show how many pages they have in preview
  • Added bundle preview
  • Added a content view mode to see contents of item/book (so it's possible to read other pages of book without opening book, or viewing actual item data (such as item names and enchantments) without actually opening a chest(with nbt), shulker box or bundle). i had to make a custom screen because it's not possible to implement more than 54 slots by using existing screens and bundles may contain 64 itemstacks (like in screenshots). it doesn't look great but it functions, i believe it's the important thing.

Related issues

closes #5189 (bundle preview implemented)

How Has This Been Tested?

Images image

content viewing (book)
image

bundle preview
image

content viewing (container)
image

food info
image

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented Oct 8, 2025

The view content setting should be removed in favour of expanding the functionality of the middle click open setting. A lot of existing functionality in the module has been duplicated by not doing this.

@noramibu
Copy link
Contributor Author

noramibu commented Oct 8, 2025

The view content setting should be removed in favour of expanding the functionality of the middle click open setting. A lot of existing functionality in the module has been duplicated by not doing this.

ngl, i didn't even remember or notice that function. I will remove view content setting and implement to middle click open setting instead

@noramibu noramibu marked this pull request as draft October 8, 2025 20:58
@noramibu
Copy link
Contributor Author

noramibu commented Oct 9, 2025

i noticed middle click option simply doesn't work, looks like Mojang changed how it handles middle click in inventory (for sake of adding sorting option on middle clicking to any slot/itemstack in inventory)

if we keep this feature work on middle click, we will simply need to get rid of a native sorting functionality of minecraft, is it worth for sake of a keybind?

I would like to recommend to remove middle click option completely, and keep view content option, so people can actually configure a key for it, instead of stucking with middle click and losing a sorting mechanic of game.

also PeekScreen is showing a 27 slots chest inventory and even with double chest inventory, it's impossible to view a bundle's contents. I can use PeekScreen for chests & shulkers and use ContainerInventoryScreen for bundles or i can keep them to use ContainerInventoryScreen (it will look worser but does how it looks matter?)

@chri-k
Copy link
Contributor

chri-k commented Oct 9, 2025

that seems to be the best option

@noramibu noramibu marked this pull request as ready for review October 9, 2025 17:58
@Wide-Cat Wide-Cat merged commit f006211 into MeteorDevelopment:master Oct 12, 2025
1 check passed
@Zipdox2
Copy link

Zipdox2 commented Oct 12, 2025

Very nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle tooltips

4 participants