Skip to content

Conversation

bradgarropy
Copy link

@bradgarropy bradgarropy commented Jun 6, 2020

What: Add support for Facebook videos.

Why: Fixes #125.

How: Added src/tranformers/Facebook.js.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

This is still a work in progress. I created the PR as a draft to reflect that. Any early feedback is appreciated!

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90ecaf8) to head (184db5d).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines          215       221    +6     
  Branches        27        27           
=========================================
+ Hits           215       221    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradgarropy
Copy link
Author

@MichaelDeBoey Okay, I think this one is ready to go!

@MichaelDeBoey MichaelDeBoey added the ⚙️ Facebook Issue or pull request regarding Facebook label Jun 7, 2020
@MichaelDeBoey MichaelDeBoey self-assigned this Jun 7, 2020
@michalkvasnicak
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Facebook Issue or pull request regarding Facebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Facebook
3 participants