Ticket #4801: invalid utf-8 in prompt #4802
Conversation
github-actions
bot
added
needs triage
egmontkob
force-pushed
the
4801_invalid_utf8_in_prompt
branch
from
6ae71e3 to
1b3bb9b
Compare
zyv
added
area: core
There was a problem hiding this comment.
i don't know the entire context, so i can't possibly approve this, but from what i do see it looks sane.
same applies to the followup patch, which i'd squash here.
the autotest doesn't cover combining ctrl codes with botched utf8, which seems like a relevant omission. as you noted, the exact semantics probably aren't all too important, but the boundary conditions should be exercised for robustness.
note that afaict, you're fixing a security hole here: root may be browsing a user's folders, which are prepared to exploit the heap overflow. say hello to a CVE process ...
…the prompt, part 1/2 Properly resynchronize immediately after some invalid UTF-8 segment, instead of swallowing some subsequent letters or possibly even walking beyond the end of the string. Signed-off-by: Egmont Koblinger <[email protected]>
…the prompt, part 2/2 Do not filter out invalid UTF-8 components, instead let them pass through as-is. This will result in mc converting them to a replacement symbol. Signed-off-by: Egmont Koblinger <[email protected]>
egmontkob
force-pushed
the
4801_invalid_utf8_in_prompt
branch
from
1b3bb9b to
cb5080d
Compare
|
Please review. I decided to go with two separate commits, without squashing them. If for some reason the second commit turns out to be undesired, we can easily revert but we'll still keep the important bugfix of the first. |
3 participants
Proposed changes
Don't assume that the prompt is valid UTF-8
Resolves: #4801
Checklist
👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈
git commit --amend -smake indent && make check)