Skip to content

rewrite TextBuffer rendering logic, optimize, adopt VBOs #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master-MC1.12
Choose a base branch
from
Open

rewrite TextBuffer rendering logic, optimize, adopt VBOs #3138

wants to merge 5 commits into from

Conversation

@asiekierka
Copy link
Contributor

@asiekierka asiekierka commented Aug 6, 2019

What does this PR change?

  • Move from using display lists to VBOs for rendering TextBuffers, single-handedly improving performance by 2x!
  • Minor optimizations across the codebase, in many areas.

What are the downsides?

  • By default, the full font is currently loaded into a massive 16MB texture. This can probably be cut in half pretty easily - anything else would require massively complicating the VBO code.
  • The VBO code can probably be optimized a little further still.

@asiekierka asiekierka added this to the OC 1.8.0 milestone Jun 8, 2022
@asiekierka asiekierka mentioned this pull request Nov 5, 2022
Open
@asiekierka asiekierka modified the milestones: OC 1.8.0, OC 1.9.0 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

OC 1.9.0

Development

Successfully merging this pull request may close these issues.

1 participant

@asiekierka