Add element IDs to advanced weight control components #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds element IDs to the Weight Type dropdown and Weights textbox in the Advanced Weight Control section of ControlNet units. The IDs follow the existing naming pattern used throughout controlnet_ui_group.py. The primary purpose is to enable compatibility with the Config Presets extension, allowing users to save and reload complex ControlNet configurations including advanced weight settings. Changes: - Added elem_id parameters to AdvancedWeightControl.render() - Added elem_ids to weight_type dropdown and weight_editor textbox - Maintained backward compatibility for cases where render is called without parameters The changes to the dropdown have been tested and confirmed working with both ControlNet and Config Presets. Changes to the advanced weights textbox will need to rely on custom code in the Config Presets to stop propagation of Weight Type events when both the Weight Type and Advanced Weights are updated as part of the same preset (otherwise the UI event for Weight Type overwrites the Advanced Weights).
|
Reviewed commit appears to enhance compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds element IDs to the Weight Type dropdown and Weights textbox in the Advanced Weight Control section of ControlNet units. The IDs follow the existing naming pattern used throughout controlnet_ui_group.py.
The primary purpose is to enable compatibility with the Config Presets extension, allowing users to save and reload complex ControlNet configurations including advanced weight settings.
Changes:
The changes to the dropdown have been tested and confirmed working with both ControlNet and Config Presets. Changes to the advanced weights textbox will need to rely on custom code in the Config Presets to stop propagation of Weight Type events when both the Weight Type and Advanced Weights are updated as part of the same preset (otherwise the UI event for Weight Type overwrites the Advanced Weights).