Downloader: ensure refresh_knowledge thread are properly closed#18709
Open
glyh wants to merge 2 commits intocompatiblefrom
Open
Downloader: ensure refresh_knowledge thread are properly closed#18709glyh wants to merge 2 commits intocompatiblefrom
glyh wants to merge 2 commits intocompatiblefrom
Conversation
running after the downloader has exited
glyh
changed the title
Member
Author
|
!ci-build-me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each peer tracked by the
Downloaderspawns arefresh_knowledgeasync thread that periodically polls for downloadable jobs. This thread was previously stopped only when the peer was forgotten (via thefinishedivar). However, the thread held no reference to the top-levelstopdeferred, so if the downloader was shut down while peers were still active, these threads would remain alive indefinitely — leaking async jobs and memory.Fix
refresh_knowledgenow derives its internalstopasDeferred.any [ forgot_peer; stop ], combining the per-peer termination signal with the downloader-level shutdown signal. The thread now terminates on whichever comes first.