[Don't merge] tmp branch to build Mesa dockers#18736
Draft
[Don't merge] tmp branch to build Mesa dockers#18736
Conversation
…ool_more_configs
Replace wait_for_bootstrap (CLI subprocess polling every 60s) with wait_for_node_init (GraphQL structured log event detection every 5s). Uses startFilteredLog/getFilteredLogEntries to detect the Starting_transition_frontier_controller event from transition_router. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…s in wait_for_node_init Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…apture init events The Starting_transition_frontier_controller log event fires before GraphQL startFilteredLog can be registered (the 10s initial delay + filter setup causes the event to be missed). Fix by passing --start-filtered-logs to the daemon CLI at startup, which captures ALL events from boot. Simplify wait_for_node_init to just poll getFilteredLogEntries with a 2s initial delay. Also fix pre-existing syntax error (double `in`) in ConfigFileOverride.validate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ushback_if_open Closed pipe should be treated as an error rather than silently dropped, per reviewer feedback from glyh. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hf test go: set log level to info
…ny log entry Previously wait_for_node_init would stop polling as soon as any log entries appeared. Now it parses each entry and verifies the event_id matches the expected starting_transition_frontier_controller event before declaring node initialization complete. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Without cacert, curl does not have the necessary certificates to download anything. This causes the daemon to fail to fetch genesis ledgers tarballs from S3 (or other remote sources). Adding cacert fixes the issue.
The Bench/Base.dhall pipeline function was not passing spec.scope to the JobSpec, causing all bench jobs to default to Scope.Full. This meant both stable and unstable perf jobs ran on every build type (PR and nightly) regardless of their intended scope assignment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…propagation fix: propagate scope to JobSpec in Bench pipeline
stop-node was using `set -e`-unsafe pattern: a standalone failing command followed by `if [ $? -ne 0 ]`. With `set -e` active the script exits before reaching the if-check. Fix by putting the command directly in the if-condition, which is exempt from `set -e`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ts_in_cmd_tests
Add cacert to nix docker definitions
… test The scanner binary path includes the mina version tag (/usr/lib/mina/storage/<rocksdb_version>/<mina_tag>/mina-rocksdb-scanner) which was hardcoded to 3.3.0. As the tag has moved on, the binary was not found at the expected path, failing the ConnectToMainnet test. Use find to discover the scanner path dynamically under each rocksdb version directory instead of hardcoding the mina version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…-network test" This reverts commit 286594d.
… test The scanner binary path includes the mina version tag (/usr/lib/mina/storage/<rocksdb_version>/<mina_tag>/mina-rocksdb-scanner) which was hardcoded to 3.3.0. As the tag has moved on, the binary was not found at the expected path, failing the ConnectToMainnet test. Use find to discover the scanner path dynamically under each rocksdb version directory instead of hardcoding the mina version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of using find to discover scanner binaries, use the GITTAG env var from export-git-env-vars.sh for the current scanner and hardcode 3.3.0 only for the legacy/stable scanner. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…er-into-compatible
…ERSION Reuse STABLE_VERSION for the stable scanner path instead of a separate hardcoded variable, and move the glob wildcard to call sites only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…arly-when-shutting-down-local-network
…shutting-down-local-network mina-local-network: fix shutdown abort when nodes are down
…move-LEGACY_MINA_VERSION-env-var connect to network: remove redundant LEGACY_MINA_VERSION
Due to a bug in glibc, certain usages of networking should be avoided, if possible. That includes the pattern present in ITN logging: active repeated creation of TCP connections, that seemed to have made the glibc bug occurance more probable. To prevent future disruption in ITN testing, it's good to disable reporting of subprocess ITN logs to daemon.
Previously, check_valid_keys checked all public keys at once without reporting which ones were invalid. Now we filter and collect only the invalid keys, and use check_signature directly instead of check_only_for_signature, making the error reporting more precise.
Threads the actual Error.t from batch verification into the `Valid_assuming variant so callers can log or report why verification failed, instead of silently dropping the error.
Updates batcher.ml to carry the Error.t from the verifier through the Valid_assuming variant, and collects all errors when building the Potentially_invalid result instead of using a placeholder string.
Error.of_list raises on empty list, so fall back to a placeholder string when collected_errors is empty.
…ss-itn-logging-by-default Disable subprocess ITN logging by default
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw-away PR used for building dockers