fully respect disable_caching option #620
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaszig
force-pushed
the
disable-caching
branch
from
ba4475a to
4f6e8bd
Compare
|
ci not my fault it seems. |
|
👀 |
1 similar comment
|
👀 |
|
This looks nice. @nateberkopec Does this meet your needs for #616 ? |
glaszig
force-pushed
the
disable-caching
branch
from
4f6e8bd to
0ba8fab
Compare
|
rebased. looking good. |
glaszig
force-pushed
the
disable-caching
branch
from
0ba8fab to
bd5c50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #616
if
disable_caching = false, don't fiddle around with cache control header still.