Skip to content

Fix simple sql bind parameters throwing errors #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix simple sql bind parameters throwing errors #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/mini_profiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,15 @@ def advanced_tools_message

def binds_to_params(binds)
return if binds.nil? || config.max_sql_param_length == 0
# map ActiveRecord::Relation::QueryAttribute to [name, value]
params = binds.map { |c| c.kind_of?(Array) ? [c.first, c.last] : [c.name, c.value] }
params = binds.map do |c|
if c.kind_of?(Array)
[c.first, c.last]
elsif c.respond_to?(:name) # ActiveRecord::Relation::QueryAttribute
[c.name, c.value]
else # Time, String, Integer
["param", c]
end
end
if (skip = config.skip_sql_param_names)
params.map { |(n, v)| n =~ skip ? [n, nil] : [n, v] }
else
Expand Down