Skip to content

Allow empty string value for xcschemes.env_value #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow empty string value for xcschemes.env_value #3165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e98584
Allow empty string value for xcschemes.env_value
ghugues Apr 6, 2025
a8a9bf5
add unit tests
ghugues Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xcodeproj/internal/xcschemes/xcschemes.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,7 @@ def _env_value(value, *, enabled = True):
checked in the scheme. An unchecked checkbox means Xcode won't
include that environment variable when running a target.
"""
if not value:
Copy link
Contributor

@brentleyjones brentleyjones Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to adjust the tests for this.

Copy link
Contributor Author

@ghugues ghugues Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not covered by unit tests so I add added a new suite with a couple tests. Let me know if this is what you had in mind.

Copy link
Contributor Author

@ghugues ghugues May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentleyjones quick reminder.

if not value and value != "":
fail("""
`value` must be provided to `xcschemes.env_value`.
""")
Expand Down