[Cherrypick] Commit Handler rewrite (#23497) #23745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I highly recommend checking out the branch, opening your IDE, and starting at `handle_consensus_commit_v2` and stepping through the whole path line by line. - When you see a comment that looks like `// DONE(commit-handler-rewrite): <message>` you can search for `<message>` and find a corresponding `TODO` line in the original handler. You can then check that the new code is doing the same thing as the old code. - Anything ending in `_v2` is usually just the original version, changed to handle `VerifiedExecutableTransaction` instead of `VerifiedSequencedConsensusTransaction` - We currently only run the new handler on the first 2 validators in the committee. This makes it easy to test for forks. Before merging, I will switch to using a protocol flag so that all validators switch atomically. (I claim that the new code is compatible, but there's no harm in being safe) - In order to have both code paths present at the same time, there is a fair amount of duplicated code in `_v2` methods. The original versions of this code will be removed after this has been rolled out. - [x] simtest, with only some validators running new handler. This found a lot of bugs - [ ] antithesis, with and without split-version / upgrade tests - [ ] I will attempt to replay mainnet/testnet commits to further verify compatibility
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ebmifa
approved these changes
Sep 25, 2025
- Fix bug in deferred transaction loading - Fix upgrade tests on antithesis by requiring the epoch flag
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick of commit handler rewrite
Test plan
Has already been extensively tested in simtest + antithesis. Will be deploying to mysten validators for further testing prior to release.