[pkg-alt] Fix simtests #23755
Merged
[pkg-alt] Fix simtests #23755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
changed the title
| let chain_id = read_api.get_chain_identifier().await?; | ||
|
|
||
| // For upgrade, we want to force the root package to have `0x0` as its address | ||
| build_config.root_as_zero = true; |
There was a problem hiding this comment.
shouldn't this also be set in publish_command function?
There was a problem hiding this comment.
discussed offline: we shouldn't be doing it for publish. We should protect from accidental dual publishes.
If someone wants to republish, they first need to remove the entry from Published file.
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
manolisliolios
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the first issue with simtest failures
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.