Make withdraw_funds_from_object public #24296
Open
+136
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
a7c2a63 to
1f5d267
Compare
lxfind
requested review from
jessiemongeon1,
mystenmark and
ronny-mysten
as code owners
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
1f5d267 to
36aa1c7
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
36aa1c7 to
d74761d
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
d74761d to
d84b945
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
d84b945 to
a072733
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
a072733 to
7e468c0
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
7e468c0 to
523fd07
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
523fd07 to
28dd2b8
Compare
mystenmark
force-pushed
the
mlogan-balance-checks
branch
2 times, most recently
from
b421a25 to
b7ee335
Compare
tnowacki
previously requested changes
Nov 20, 2025
crates/sui-framework/packages/sui-framework/sources/funds_accumulator.move
Outdated
Show resolved
Hide resolved
mystenmark
force-pushed
the
mlogan-balance-checks
branch
from
b7ee335 to
7c5fd41
Compare
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
28dd2b8 to
91d0dfc
Compare
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
2 times, most recently
from
08e6017 to
24eac85
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
reviewed
Nov 20, 2025
tnowacki
reviewed
Nov 21, 2025
Contributor
tnowacki
left a comment
tnowacki
left a comment
There was a problem hiding this comment.
Move side of things LGTM. I have not looked too closely at the various unit tests so I will leave it to @mystenmark to approve
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
24eac85 to
023a778
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
023a778 to
dab6bc6
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Nov 25, 2025
|
|
||
| /// Attempted to check a feature flag name that is not valid UTF-8. | ||
| #[allow(unused_const)] | ||
| #[error(code = 1)] |
Contributor
There was a problem hiding this comment.
If you emit this from the native, I don't think you will get a message ever... though maybe @tzakian has ideas
lxfind
force-pushed
the
xun/enable-object-withdraw-move
branch
from
dab6bc6 to
f2d2bb0
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Contributor
Author
|
Rebased on top of #24422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the Move API public for object balance withdraw.
Check in runtime to make sure it cannot be called if accumulator is not enabeld.
Test plan
Added a test to check that when accumulator is disabled, one cannot withdraw from objects.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.