Open
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (78.94%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 93.55% 93.01% -0.54%
==========================================
Files 7 7
Lines 667 673 +6
==========================================
+ Hits 624 626 +2
- Misses 43 47 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Reductionist will only report 500 internal server errors - here we check JSON body - Any other error response we check text of body - this way we catch the likes of HAProxy connection limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #291
Changes in Client to emit data for Anon bucket. @maxstack it currently doesn't work from Reductionist's end, Reductionist throws a 401, could you have a look pls mate 🍺 - the test to look at is
tests/test_real_s3.py::test_anon_s3see the failed test here https://github.com/NCAS-CMS/PyActiveStorage/actions/runs/23255142731/job/67607820849?pr=314Before you get started
Checklist