Skip to content

Conversation

@keke521jie
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Issue Number: close #9276

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@keke521jie keke521jie requested a review from Laffery as a code owner September 19, 2025 03:47
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (b0a4287) to head (66e386d).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9429      +/-   ##
==========================================
- Coverage   92.12%   91.39%   -0.74%     
==========================================
  Files         561      561              
  Lines       19631    19738     +107     
  Branches     3107     3033      -74     
==========================================
- Hits        18086    18039      -47     
- Misses       1206     1371     +165     
+ Partials      339      328      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pxSizes[nextIndex] -= mergedOffset;
this.innerSizes.set(pxSizes);

const percentageSizes = pxSizes.map(size => size / containerSize);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动是出于什么?按照当前设计,innerSizes 是保存实际像素大小的

  /**
   * Derived from defaultSize of each panel.
   * After that it will be updated by the resize event with **real** size in pixels.
   */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的实现在拖动调整大小后手动缩小放大屏幕会出现
image
这种情况。innerSizes的像素值没有计算对导致sizes百分比计算错误
image
所以改成了百分比计算

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splitter shows wrong logic for percentage case

3 participants