Skip to content

reduce rename-split test-data to minimal possible size#719

Merged
ceblanton merged 6 commits intorename-splitfrom
copilot/sub-pr-717
Feb 4, 2026
Merged

reduce rename-split test-data to minimal possible size#719
ceblanton merged 6 commits intorename-splitfrom
copilot/sub-pr-717

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

Describe your changes

Restored previously deleted test fixtures while minimizing atmos_daily and ocean_annual test files:

Test Data Restored (23 CDL files):

  • river_month, ocean_annual, ocean_static (native/regrid, input/output)
  • fail_filenames and fail_nofiles test cases

Test Configuration Updated:

  • Restored 10-case parametrization (from 2): daily, monthly, annual, static frequencies × native/regrid + 2 failure cases
  • Updated tile file assertion: 8 files (was 4)

Minimized Test Files:

  • atmos_daily: 358 lines, 9.1KB (94% reduction from original 5,816 lines, 290KB)
    • Grid: 2×2 (was 15×10), vertical levels: 2 (was 66), timesteps: 181 (unchanged)
  • ocean_annual: 97 lines, 2.4KB (97% reduction from original 2,835 lines, 159KB)
    • Grid: 2×2 (was 15×10), vertical levels: 2 (was 75), time: 1 timestep (unchanged)

Other Test Files: Remain at original size (river_month: 232 lines, ocean_static: 104 lines)

Test Results: 15 total (13 passed, 2 xfail)

Overall Impact: Total test directory size reduced from 1.1M to 444K (60% reduction)

Issue ticket number and link (if applicable)

N/A

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Copilot AI changed the title [WIP] Convert fre-workflows rename-split script to fre-cli python Reduce rename-split test CDL files to minimal dataset Feb 4, 2026
Copilot AI requested a review from ilaflott February 4, 2026 16:37
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Copilot AI changed the title Reduce rename-split test CDL files to minimal dataset Restore full rename-split test suite with minimal atmos_daily fixtures Feb 4, 2026
@ilaflott ilaflott requested a review from ceblanton February 4, 2026 16:45
@ilaflott ilaflott changed the title Restore full rename-split test suite with minimal atmos_daily fixtures redeuce rename-split test-data to minimal possible size Feb 4, 2026
@ilaflott ilaflott changed the title redeuce rename-split test-data to minimal possible size reduce rename-split test-data to minimal possible size Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (4ae680b) to head (87c5f3a).

Additional details and impacted files
@@              Coverage Diff              @@
##           rename-split     #719   +/-   ##
=============================================
  Coverage         82.94%   82.94%           
=============================================
  Files                69       69           
  Lines              4655     4655           
=============================================
  Hits               3861     3861           
  Misses              794      794           
Flag Coverage Δ
unittests 82.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae680b...87c5f3a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilaflott
Copy link
Member

ilaflott commented Feb 4, 2026

@copilot

  • this is what we want
  • now do the ocean_annual cases
  • leave all other cases alone at this point. only reduce the ocean_annual cases.

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

@copilot

  • this is what we want
  • now do the ocean_annual cases
    ...

Completed in commit b3300ce. ocean_annual test files reduced from 2835 lines to 97 lines (97% reduction):

  • Grid: 15×10 → 2×2
  • Vertical levels: 75 → 2
  • Directory size: 1.1M → 444K (60% total reduction)

All other test cases remain unchanged. All 15 tests pass.

@ilaflott
Copy link
Member

ilaflott commented Feb 4, 2026

annoying but because i removed the one-off workflow trigger, it un-associated the workflow from this PR. the proof-in-pudding workflow is linked here

@ilaflott ilaflott marked this pull request as ready for review February 4, 2026 17:14
@ilaflott
Copy link
Member

ilaflott commented Feb 4, 2026

Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!!! and thank you

@ceblanton ceblanton merged commit ab3ba21 into rename-split Feb 4, 2026
1 check passed
@ceblanton ceblanton deleted the copilot/sub-pr-717 branch February 4, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants