Remove excess call to wp_enqueue_script()#18
Open
evansolomon wants to merge 1 commit intoNUKnightLab:masterfrom
evansolomon:remove-extra-enqueue
Open
Remove excess call to wp_enqueue_script()#18evansolomon wants to merge 1 commit intoNUKnightLab:masterfrom evansolomon:remove-extra-enqueue
evansolomon wants to merge 1 commit intoNUKnightLab:masterfrom
evansolomon:remove-extra-enqueue
Conversation
jQuery is already declared as a dependency, so there's no need to explicitly enqueue it on its own.
kadamwhite
approved these changes
Dec 17, 2023
kadamwhite
left a comment
kadamwhite
left a comment
There was a problem hiding this comment.
+1. If another plugin for some reason dequeue'd the verite-timeline-embed script, jQuery wouldn't be properly dequeue'd with it — this is admittedly an edge case, but I agree the suggested change is more technically correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jQuery is already declared as a dependency, so there's no need to explicitly enqueue it on its own.