Skip to content

Add xatt trimming for multitask beam decoding#15466

Open
azziko wants to merge 6 commits intoNVIDIA-NeMo:mainfrom
azziko:fix-xatt-trimming
Open

Add xatt trimming for multitask beam decoding#15466
azziko wants to merge 6 commits intoNVIDIA-NeMo:mainfrom
azziko:fix-xatt-trimming

Conversation

@azziko
Copy link

@azziko azziko commented Mar 5, 2026

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adds a missing trimming of the cross-attention for multitask beam decoding

Collection: [ASR]

Changelog

  • Trim pads and eos from cross-attention.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [x ] Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

This PR is related to #15419 and #15229

Signed-off-by: azziko <sharipov.wdev@gmail.com>
@github-actions github-actions bot added the ASR label Mar 5, 2026
azziko and others added 2 commits March 5, 2026 13:14
@mgaido91
Copy link
Contributor

mgaido91 commented Mar 5, 2026

The change looks good to me, I'd add a UT though, thanks!

azziko and others added 2 commits March 5, 2026 18:30
Signed-off-by: azziko <sharipov.wdev@gmail.com>
Signed-off-by: azziko <azziko@users.noreply.github.com>
@azziko
Copy link
Author

azziko commented Mar 7, 2026

Hello @nithinraok,

Could you please review the PR?

@chtruong814 chtruong814 added the needs-follow-up Issue needs follow-up label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants