Fix multitask transcribe override_config timestamps handling#15474
Open
gmartini2000 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
Fix multitask transcribe override_config timestamps handling#15474gmartini2000 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
gmartini2000 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the checks appears to be failing due to the workflow not being able to find the PR head commit from the fork:
repositoryto${{ github.event.pull_request.head.repo.full_name }}for forked PRsThis looks like a workflow checkout/diff issue rather than a code issue on this PR.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Fixes an issue where
EncDecMultiTaskModel.transcribe()overwrites thetimestampsvalue provided throughoverride_configwhen thetimestampsparameter is left as its default (None). The fix ensures that timestamps defined inMultiTaskTranscriptionConfigare preserved unless thetimestampsparameter is explicitly provided.Collection: ASR
Changelog
EncDecMultiTaskModel.transcribe()to preventoverride_config.timestampsfrom being overwritten by the defaulttimestamps=Noneparameter.MultiTaskTranscriptionConfigare preserved when usingoverride_config.Usage
Example demonstrating usage of
override_configwith timestamps preserved.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information