Skip to content

Check consistency of multiplier #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zasdfgbnm wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Check consistency of multiplier #5708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions csrc/multidevice/execution_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ std::vector<int64_t> unshardedSizes(
"Producing logical axis not found for ",
sharded_id);

// Global map to track extent -> multiplier relationships
static std::unordered_map<Val*, int64_t> extent_to_multiplier_map;

auto multiplier = [&]() -> int64_t {
if (parallel_type == ParallelType::Stream) {
// TODO(#5525): hack for MultiDeviceExecutor. MultiDeviceExecutor looks
Expand Down Expand Up @@ -101,6 +104,22 @@ std::vector<int64_t> unshardedSizes(

NVF_THROW("Unexpected parallel type: ", parallel_type);
}();

// Check consistency: for the same extent, we should always get the same multiplier
Val* extent = sharded_id->extent();
auto it = extent_to_multiplier_map.find(extent);
if (it != extent_to_multiplier_map.end()) {
NVF_ERROR(
it->second == multiplier,
"Inconsistent multiplier for extent ",
extent->toString(),
": expected ",
it->second,
" but got ",
multiplier);
} else {
extent_to_multiplier_map[extent] = multiplier;
}
unsharded_sizes.at(sharded_axis) *= multiplier;
}

Expand Down
Loading