Support exclude module for exporting mcore models#743
Open
Conversation
Signed-off-by: weimingc <17592131+meenchen@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 74.68% 74.65% -0.03%
==========================================
Files 192 192
Lines 18950 18969 +19
==========================================
+ Hits 14153 14162 +9
- Misses 4797 4807 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: weimingc <17592131+meenchen@users.noreply.github.com>
cjluo-nv
reviewed
Jan 13, 2026
| def _get_quantization_format(self, module: torch.nn.Module): | ||
| return get_quantization_format(module) | ||
|
|
||
| def _get_unquantized_layers(self, state_dict: dict[str, torch.Tensor]) -> list[str]: |
Collaborator
There was a problem hiding this comment.
this is a bit hacky though and we have to maintain the list. @ChenhanYu WDYT?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Improvement
Overview: Currently mcore export hardcode the exlucde module and does not support disabling quantization for layers.
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information