fix(policies): guard extractPresetEntries against null/undefined input

[Junior00619]

Problem

extractPresetEntries() throws an unhandled TypeError: Cannot read properties of null (reading 'match') when called with null or undefined. The function is exported as part of the public module API but lacks the same defensive guard that its sibling parseCurrentPolicy() already implements.

The current call site in applyPreset() is protected indirectly — loadPreset() returns null and the caller bails before reaching extractPresetEntries() — but direct consumers of the exported function hit the crash:

const { extractPresetEntries } = require("./policies");
extractPresetEntries(null); // TypeError

Fix
Add an early-return null guard consistent with the existing parseCurrentPolicy() pattern (line 79). One line, zero behavioral change for the happy path.

Tests
Added 15 regression tests for two exported pure functions that previously had zero direct test coverage:

extractPresetEntries (8 tests): null, undefined, empty string, missing section, extraction correctness, trailing whitespace stripping, real preset integration, metadata exclusion
parseCurrentPolicy (7 tests): null, undefined, empty string, metadata stripping, no-separator passthrough, whitespace trimming, edge-case separator position
All 37 policy tests pass. Full suite: 615 pass, 2 pre-existing failures in install-preflight.test.js (unrelated).

[coderabbitai]

📝 Walkthrough

Walkthrough

A defensive improvement to extractPresetEntries() that early-returns null for falsy input before regex matching, combined with comprehensive test coverage for both extractPresetEntries() and parseCurrentPolicy() functions, validating behavior for edge cases and real preset data.

Changes

Cohort / File(s)	Summary
Defensive Input Handling bin/lib/policies.js	Added early null-check in extractPresetEntries() to short-circuit before regex matching when input is falsy.
Test Coverage Expansion test/policies.test.js	Added 115 lines of test cases for extractPresetEntries() and parseCurrentPolicy(), covering null/undefined/empty inputs, YAML section extraction, metadata header removal, separator handling, and validation against all real presets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A null-check hops in line,
Before the regex dares to shine,
Tests now dance in every case,
Presets parsed at proper pace! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main change: adding a guard against null/undefined input to extractPresetEntries, which is exactly what the one-line code change accomplishes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Junior00619]

@cv friendly ping , this is ready for review whenever you have a moment 🙏

[wscurran]

✨ Thanks for submitting this fix with a detailed summary, it addresses a bug in the extractPresetEntries function, which could improve the stability and reliability of NemoClaw.

[jyaunches]

@Junior00619 @cv This looks good to merge.

[Junior00619]

@Junior00619 @cv This looks good to merge.

Nice! Always a pleasure :))