Skip to content

fix print_layout printf format in device code #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix print_layout printf format in device code #2688

wants to merge 3 commits into from

Conversation

@Aminsed
Copy link

@Aminsed Aminsed commented Oct 12, 2025 •
edited
Loading

@Aminsed
fix print_layout printf format in device code
dced797 
* Replace %.*s format specifier with explicit loop
* Remove unused delim variable

The printf format %.*s with dynamic width does not work correctly
in CUDA device code, causing literal %.*s to appear in output.

Fixes NVIDIA#2496
ccecka
ccecka reviewed Oct 13, 2025
View reviewed changes
ccecka
ccecka reviewed Oct 13, 2025
View reviewed changes
@Aminsed
Copy link
Author

Aminsed commented Oct 13, 2025

Thanks @ccecka !

@Aminsed Aminsed requested a review from ccecka October 13, 2025 19:15
@Aminsed
Copy link
Author

Aminsed commented Oct 19, 2025

@ccecka @hwu36 @Junkai-Wu could we merge?

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ccecka ccecka ccecka approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

inactive-30d

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] The print_layout function failed to format the output correctly.

2 participants

@Aminsed @ccecka